This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
A simple POC to change non KRM files to a structured k8s resource #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e via initContainer on the cluster side
bgrant0607
reviewed
Jul 29, 2022
ghost/mariadb/configmap-mariadb.yaml
Outdated
| port=3306 | ||
| socket=/opt/bitnami/mariadb/tmp/mysql.sock | ||
| pid-file=/opt/bitnami/mariadb/tmp/mysqld.pid | ||
| cm.mysqld.skip-name-resolve: "false" |
There was a problem hiding this comment.
I assume there's also a program to generate this format from INI?
There was a problem hiding this comment.
Well, I actually just use the Sublime multi-line operation to convert the file.
To better reflect the Option 2 approach, added the python script to generate this from INI (second commit).
…l key-value pair content in ConfigMap.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Sane merge behavior for non-KRM files
This PR structures a INI file in the form of
ConfigMapkey-value pairs in the client side, so that kpt can do granular merging during update, and re-generate the actual INI by defining a custom initContainer (env-to-ini) on the cluster side.